[Insight-developers] Patch submission to SimpleITK?

Williams, Norman K norman-k-williams at uiowa.edu
Tue Aug 14 13:35:20 EDT 2012


There was this bug report from Hans:
https://issues.itk.org/jira/browse/SIMPLEITK-296

CLang was pickier than our other supported compilers, and unfortunately,
the fix broke Visual Studio builds.

I have a patch that fixes this problem with a preprocessor symbol that is
set to 'template' only for clang, by adding a preprocessor conditional to
sitConfigure.h.in

This is in my github fork of SITK:
https://github.com/BRAINSia/SimpleITK/commits/CLangCompileFix

So how and to whom should I send this patch?  I don't really follow
SimpleITK development so I don't know if there's an established SimpleITK
equivalent of the Gerrit workflow for ITK.

--
Kent Williams norman-k-williams at uiowa.edu






________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________


More information about the Insight-developers mailing list