[Insight-developers] Please wait for robot builds before merging gerrit topics

[Bill Lorensen]

OK with me.

BTW, how did this error sneak through. I see that the continuous reported
it yesterday, but the gerrit ronot builds for the patch were OK.

Bill


On Fri, Nov 2, 2012 at 4:26 PM, Bradley Lowekamp <blowekamp at mail.nih.gov>wrote:

> Bill,
>
> It's the end of the work day for myself. My patches compiled on my system
> and the one Mac that is responsive on CDash at home. They are rather
> trivial changes that have been approved by others. If they don't fix the
> problem at hand the dashboard is not going to be worse off. I am going
> ahead and merging them.
>
> Brad
>
> On Nov 2, 2012, at 4:13 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>
> Did you build and test this on a Visual Studio system? If so, I have no
> problems with merging it.
>
> On Fri, Nov 2, 2012 at 3:34 PM, Bradley Lowekamp <blowekamp at mail.nih.gov>wrote:
>
>> I am not sure I see the point to that as it's expected that it will have
>> a compilation error due to the unresolved mesh test.
>>
>> I'd like to get the patches in to fix the dashboard I completed before
>> 9am merged before I go home today so they will be fixed for tomorrow.
>>
>> Brad
>>
>> On Nov 2, 2012, at 3:21 PM, Bill Lorensen <bill.lorensen at gmail.com>
>> wrote:
>>
>> I think we should wait for a PC build to complete.
>>
>> On Fri, Nov 2, 2012 at 1:30 PM, Bradley Lowekamp <blowekamp at mail.nih.gov>wrote:
>>
>>> Bill,
>>>
>>> It appears that only the Mac factory is reporting on gerrit today.
>>>
>>> I submitted 2 patches to address test failures and compilation errors
>>> which are occurring on the dashboard.
>>>
>>> Error which is resolved by the patch you linked below, only occurs on
>>> non-windows builds with shared libraries. None of the robot builds are
>>> configured that way.
>>>
>>> When do you propose that I can merge my patches?
>>>
>>> Thanks,
>>> Brad
>>>
>>> On Nov 2, 2012, at 10:56 AM, Bill Lorensen <bill.lorensen at gmail.com>
>>> wrote:
>>>
>>> Folks,
>>>
>>> I see gerrit topics being merged before the robot builds complete.For
>>> example, this topic: http://review.source.kitware.com/#/c/8262/ was
>>> merged, yet the robot build shows errors on windows:
>>> http://open.cdash.org/index.php?project=Insight&filtercount=2&field1=buildname/string&compare1=63&value1=VTKPolyDataMeshIOTensorPixels2961-Ifb523cf-2&field2=buildstarttime/date&compare2=83&value2=2012-10-31
>>>
>>> I see this topic: http://review.source.kitware.com/#/c/8295/ has been
>>> approved, but the robots have not reported yet.
>>>
>>> Now the nightly has errors and gerrit topics are showing the same
>>> errors. Compiler errors in the robot builds caused by previously merged
>>> topics are bad.
>>>
>>> Bill
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.php
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>>
>>>
>>
>>
>> --
>> Unpaid intern in BillsBasement at noware dot com
>>
>>
>>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
>
>
>


-- 
Unpaid intern in BillsBasement at noware dot com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-developers/attachments/20121102/d18c877f/attachment.htm>