[Insight-developers] Removal of ITK_TEMPLATE_TXX causes Slicer problems

[Johnson, Hans J]

Bill,

I think that the approach I took to ITK_TEMPLATE_TXX was too heavy handed.
 I was hoping to get around to putting that back last week, but it fell
off the radar.

This patch restores the default behavior in the default case, and provide
a better error message otherwise.

http://review.source.kitware.com/8492

Hans
=================================================================
Hans J. Johnson, Ph.D.
Assistant Professor, Department of Psychiatry

Mailing Address:
W274 GH                             Email: hans-johnson at uiowa.edu
200 Hawkins Drive                   Phone: (319) 353 8587
The University of Iowa
Iowa City, IA 52242






-----Original Message-----
From: Bill Lorensen <bill.lorensen at gmail.com>
Date: Tuesday, November 13, 2012 12:55 PM
To: Hans Johnson <hans-johnson at uiowa.edu>
Cc: ITK <insight-developers at itk.org>
Subject: Removal of ITK_TEMPLATE_TXX causes Slicer problems

Hans,

Now that ITK_TEMPLATE_TXX has been removed from ITKv4, a number of
Slicer files that use it do not compile or link. I think the
ITK_TEMPLATE_TXX is in the Slicer code because it was cut/paste from
other code.

We can
1) Put
#define ITK_TEMPLATE_TXX 0
back in itkMacros.h
We could include a warning
2) Remove the ITK_TEMPLATE_TXX from the Slicer files that use it. I
think they will still build witk ITKv3.

I like 1) because the error that is produced is tough to track
down(ends up as a linker error). Also, it will help other apps that
also used ITK_TEMPLATE_TXX by accident.

Bill

--
Unpaid intern in BillsBasement at noware dot com



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________