[Insight-users] itkEuler2DTransform: modification to m_RotationMatrix during Compose is lost

[Julien Jomier]

Jim,

That's a good point. It's only working if the flag is off at this moment.
I'll put a fix as soon as I can.

Julien

> -----Original Message-----
> From: insight-users-admin at itk.org 
> [mailto:insight-users-admin at itk.org] On Behalf Of Miller, 
> James V (Research)
> Sent: Thursday, April 01, 2004 1:14 PM
> To: 'Julien Jomier'; 'Charl P. Botha'; insight-users at itk.org
> Subject: RE: [Insight-users] itkEuler2DTransform: 
> modification to m_RotationMatrix during Compose is lost
> 
> 
> Julien,
> 
> Does your decomposition of the angles from the matrix need to 
> take into account the m_ComputeZYX flag?
> 
> Jim
> 
> -----Original Message-----
> From: Julien Jomier [mailto:jjomier at cs.unc.edu]
> Sent: Thursday, April 01, 2004 10:48 AM
> To: 'Charl P. Botha'; insight-users at itk.org
> Subject: RE: [Insight-users] itkEuler2DTransform: 
> modification to m_RotationMatrix during Compose is lost
> 
> 
> Hi Charl,
> 
> I just closed this bug. It is now fixed in the repository for 
> both itkEuler2DTransform and itkEuler3DTransform.
> 
> Thanks for the report,
> 
> Julien
> 
> > -----Original Message-----
> > From: insight-users-admin at itk.org
> > [mailto:insight-users-admin at itk.org] On Behalf Of Charl P. Botha
> > Sent: Tuesday, March 30, 2004 8:47 AM
> > To: 'insight-users at itk.org'
> > Subject: [Insight-users] itkEuler2DTransform: modification to 
> > m_RotationMatrix during Compose is lost
> > 
> > 
> > I've reported the following as Bug #726:
> > 
> > The Python example below shows how an Euler2DTransform simply
> > loses rotation during a transform concatenation.  This is due 
> > to the fact that
> > itk::Rigid2DTransform::Compose() concatenates the 
> > m_RotationMatrix, but that there's no code to set the new 
> > itk::Euler2DTransform::m_Angle from the m_RotationMatrix.  In 
> > this way, the rotation is lost.
> > 
> > # create two Euler2D transforms and set to identity
> > a = itk.itkEuler2DTransform_New()
> > a.SetIdentity()
> > 
> > b = itk.itkEuler2DTransform_New()
> > b.SetIdentity()
> > 
> > # set and confirm rotation to 0.2
> > a.GetParameters().SetElement(0,0.2)
> > a.SetRotation(0.2)
> > a.GetParameters().GetElement(0)
> > 0.20000000000000001
> > 
> > # concatenate b and a
> > b.Compose(a.GetPointer(),0)
> > 
> > # resultant rotation is 0.0!
> > b.GetParameters().GetElement(0)
> > 0.0
> > 
> > --
> > charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/
> > 
> > 
> > _______________________________________________
> > Insight-users mailing list
> > Insight-users at itk.org
> > http://www.itk.org/mailman/listinfo/insight-> users
> > 
> 
> _______________________________________________
> Insight-users mailing list
> Insight-users at itk.org
> http://www.itk.org/mailman/listinfo/insight-users
> _______________________________________________
> Insight-users mailing list
> Insight-users at itk.org
> http://www.itk.org/mailman/listinfo/insight-users
>