[Insight-users] Minor bug in new OtsuMultipleThresholdsCalculator?

[Zachary Pincus]

Luca,

I completely agree -- it seems like MeanType must remain double for 
reasonable operation.

The rest of the vectors seem like they can either just be of type 
MeasurementType, or be double vectors internally that are then cast to 
MeasurementType before passing them to the histogram or to the user. 
I'm not sure which of these two makes more sense.

Zach



On Mar 5, 2004, at 12:37 AM, lucantiga at softhome.net wrote:

> Hi Zach,
>  I agree that there should be more consistency as to types. I think 
> that
> the following modifications should be done:
>
> in itkOtsuMultipleThresholdsCalculator.h
>
> typedef double MeanType;
> typedef std::vector<MeanType> MeanVectorType;
>
>   bool IncrementThresholds(InstanceIdentifierVectorType& thresholdIds,
> MeanType totalMean, MeanVectorType& classMean, FrequencyVectorType&
> classFrequency);
>
> and the necessary casts and declarations in
> itkOtsuMultipleThresholdsCalculator.txx
>
> I think that keeping MeanType double is necessary. Any thoughts?
>
> Since the patch for a bug I found a couple of days ago hasn't been
> applied yet, I could correct everything and post it here, and then you
> could take a final look at the modified versions.
>
> Let me know
>
> Luca
>
> --
> Luca Antiga, PhD
> ----------------------------------------------
> Biomedical Technologies Laboratory
> Bioengineering Department,
> Mario Negri Institute
> Villa Camozzi, 24020, Ranica (BG), Italy
> ----------------------------------------------
> phone: +39 035 4535-381
> email: antiga at marionegri.it
> web:   http://villacamozzi.marionegri.it/~luca
> ----------------------------------------------
>
> _______________________________________________
> Insight-users mailing list
> Insight-users at itk.org
> http://www.itk.org/mailman/listinfo/insight-users
>