No subject
Mon Aug 10 18:29:21 EDT 2009
fact that these classes have build a cycle of
relationships is an indication that they
"know to much"
about the others, and that you are in the
borderline situation of breaking their
encapsulation.
In general, if Class A knows about class B,
then Class B shouldn't need to know about
Class A.
You may want to reconsider the design,
before you go for adopting the WeakPointer.
Regards,
Luis
------------------------
Here is the Valgrind output for both cases:
valgrind --leak-check=3Dfull ./SmartPointer1
=3D=3D8256=3D=3D Memcheck, a memory error detector.
=3D=3D8256=3D=3D Copyright (C) 2002-2008, and GNU GPL'd, by Julian Seward e=
t al.
=3D=3D8256=3D=3D Using LibVEX rev 1884, a library for dynamic binary transl=
ation.
=3D=3D8256=3D=3D Copyright (C) 2004-2008, and GNU GPL'd, by OpenWorks LLP.
=3D=3D8256=3D=3D Using valgrind-3.4.1-Debian, a dynamic binary instrumentat=
ion
framework.
=3D=3D8256=3D=3D Copyright (C) 2000-2008, and GNU GPL'd, by Julian Seward e=
t al.
=3D=3D8256=3D=3D For more details, rerun with: -v
=3D=3D8256=3D=3D
A Constructor
B Constructor
C Constructor
=3D=3D8256=3D=3D
=3D=3D8256=3D=3D ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 21 fr=
om 1)
=3D=3D8256=3D=3D malloc/free: in use at exit: 160 bytes in 3 blocks.
=3D=3D8256=3D=3D malloc/free: 4 allocs, 1 frees, 168 bytes allocated.
=3D=3D8256=3D=3D For counts of detected errors, rerun with: -v
=3D=3D8256=3D=3D searching for pointers to 3 not-freed blocks.
=3D=3D8256=3D=3D checked 113,372 bytes.
=3D=3D8256=3D=3D
=3D=3D8256=3D=3D 160 (56 direct, 104 indirect) bytes in 1 blocks are
definitely lost in loss record 3 of 3
=3D=3D8256=3D=3D at 0x40269EE: operator new(unsigned int) (vg_replace_ma=
lloc.c:224)
=3D=3D8256=3D=3D by 0x805DD8E: itk::B::New() (SmartPointer1.cxx:66)
=3D=3D8256=3D=3D by 0x805D00A: main (SmartPointer1.cxx:92)
=3D=3D8256=3D=3D
=3D=3D8256=3D=3D LEAK SUMMARY:
=3D=3D8256=3D=3D definitely lost: 56 bytes in 1 blocks.
=3D=3D8256=3D=3D indirectly lost: 104 bytes in 2 blocks.
=3D=3D8256=3D=3D possibly lost: 0 bytes in 0 blocks.
=3D=3D8256=3D=3D still reachable: 0 bytes in 0 blocks.
=3D=3D8256=3D=3D suppressed: 0 bytes in 0 blocks.
valgrind --leak-check=3Dfull ./SmartPointer2
=3D=3D8259=3D=3D Memcheck, a memory error detector.
=3D=3D8259=3D=3D Copyright (C) 2002-2008, and GNU GPL'd, by Julian Seward e=
t al.
=3D=3D8259=3D=3D Using LibVEX rev 1884, a library for dynamic binary transl=
ation.
=3D=3D8259=3D=3D Copyright (C) 2004-2008, and GNU GPL'd, by OpenWorks LLP.
=3D=3D8259=3D=3D Using valgrind-3.4.1-Debian, a dynamic binary instrumentat=
ion
framework.
=3D=3D8259=3D=3D Copyright (C) 2000-2008, and GNU GPL'd, by Julian Seward e=
t al.
=3D=3D8259=3D=3D For more details, rerun with: -v
=3D=3D8259=3D=3D
A Constructor
B Constructor
C Constructor
C Destructor
B Destructor
A Destructor
=3D=3D8259=3D=3D
=3D=3D8259=3D=3D ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 21 fr=
om 1)
=3D=3D8259=3D=3D malloc/free: in use at exit: 0 bytes in 0 blocks.
=3D=3D8259=3D=3D malloc/free: 4 allocs, 4 frees, 168 bytes allocated.
=3D=3D8259=3D=3D For counts of detected errors, rerun with: -v
=3D=3D8259=3D=3D All heap blocks were freed -- no leaks are possible.
--00151758f83e2a300b047543d5e5
Content-Type: text/plain; charset=US-ASCII; name="CMakeLists.txt"
Content-Disposition: attachment; filename="CMakeLists.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g0gnrzq42
Q01BS0VfTUlOSU1VTV9SRVFVSVJFRChWRVJTSU9OIDIuNCkKSUYoQ09NTUFORCBDTUFLRV9QT0xJ
Q1kpCiAgQ01BS0VfUE9MSUNZKFNFVCBDTVAwMDAzIE5FVykKRU5ESUYoQ09NTUFORCBDTUFLRV9Q
T0xJQ1kpCgoKUFJPSkVDVChTbWFydFBvaW50ZXIpCgpGSU5EX1BBQ0tBR0UoSVRLIFJFUVVJUkVE
KQpJTkNMVURFKCR7SVRLX1VTRV9GSUxFfSkKCkFERF9FWEVDVVRBQkxFKFNtYXJ0UG9pbnRlcjEg
U21hcnRQb2ludGVyMS5jeHggKQpUQVJHRVRfTElOS19MSUJSQVJJRVMoU21hcnRQb2ludGVyMSBJ
VEtDb21tb24pCgpBRERfRVhFQ1VUQUJMRShTbWFydFBvaW50ZXIyIFNtYXJ0UG9pbnRlcjIuY3h4
ICkKVEFSR0VUX0xJTktfTElCUkFSSUVTKFNtYXJ0UG9pbnRlcjIgSVRLQ29tbW9uKQo=
--00151758f83e2a300b047543d5e5
Content-Type: text/x-c++src; charset=US-ASCII; name="SmartPointer1.cxx"
Content-Disposition: attachment; filename="SmartPointer1.cxx"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g0gnra2n0
I2luY2x1ZGUgIml0a09iamVjdC5oIgojaW5jbHVkZSAiaXRrT2JqZWN0RmFjdG9yeS5oIgoKbmFt
ZXNwYWNlIGl0awp7CgpjbGFzcyBBIDogcHVibGljIE9iamVjdAp7CnB1YmxpYzoKICB0eXBlZGVm
IEEgICAgICAgICAgICAgICAgICAgICAgICAgU2VsZjsKICB0eXBlZGVmIE9iamVjdCAgICAgICAg
ICAgICAgICAgICAgU3VwZXJjbGFzczsKICB0eXBlZGVmIFNtYXJ0UG9pbnRlcjxTZWxmPiAgICAg
ICAgUG9pbnRlcjsKICB0eXBlZGVmIFNtYXJ0UG9pbnRlcjxjb25zdCBTZWxmPiAgQ29uc3RQb2lu
dGVyOwoKICBpdGtOZXdNYWNybyhTZWxmKTsKcHJvdGVjdGVkOgogIEEoKSB7IHN0ZDo6Y291dCA8
PCAiQSBDb25zdHJ1Y3RvciIgPDwgc3RkOjplbmRsOyB9CiAgdmlydHVhbCB+QSgpIHsgc3RkOjpj
b3V0IDw8ICJBIERlc3RydWN0b3IiIDw8IHN0ZDo6ZW5kbDsgfQoKcHJpdmF0ZToKfTsKCgpjbGFz
cyBCOwoKY2xhc3MgQyA6IHB1YmxpYyBPYmplY3QKewpwdWJsaWM6CiAgdHlwZWRlZiBDICAgICAg
ICAgICAgICAgICAgICAgICAgIFNlbGY7CiAgdHlwZWRlZiBPYmplY3QgICAgICAgICAgICAgICAg
ICAgIFN1cGVyY2xhc3M7CiAgdHlwZWRlZiBTbWFydFBvaW50ZXI8U2VsZj4gICAgICAgIFBvaW50
ZXI7CiAgdHlwZWRlZiBTbWFydFBvaW50ZXI8Y29uc3QgU2VsZj4gIENvbnN0UG9pbnRlcjsKCiAg
aXRrTmV3TWFjcm8oU2VsZik7CgogIHZvaWQgU2V0KCBjb25zdCBBICogYSApCiAgICB7CiAgICB0
aGlzLT5tX0EgPSBhOwogICAgfQoKICAgdm9pZCBTZXQoIGNvbnN0IEIgKiBiICkKICAgIHsKICAg
IHRoaXMtPm1fQiA9IGI7CiAgICB9Cgpwcm90ZWN0ZWQ6CiAgQygpIHsgc3RkOjpjb3V0IDw8ICJD
IENvbnN0cnVjdG9yIiA8PCBzdGQ6OmVuZGw7IH0KICB2aXJ0dWFsIH5DKCkgeyBzdGQ6OmNvdXQg
PDwgIkMgRGVzdHJ1Y3RvciIgPDwgc3RkOjplbmRsOyB9Cgpwcml2YXRlOgogIEE6OkNvbnN0UG9p
bnRlciAgICBtX0E7CgogIHR5cGVkZWYgU21hcnRQb2ludGVyPGNvbnN0IEI+ICAgQlBvaW50ZXI7
CiAgQlBvaW50ZXIgICAgICAgICAgIG1fQjsKfTsKCgpjbGFzcyBCIDogcHVibGljIE9iamVjdAp7
CnB1YmxpYzoKICB0eXBlZGVmIEIgICAgICAgICAgICAgICAgICAgICAgICAgU2VsZjsKICB0eXBl
ZGVmIE9iamVjdCAgICAgICAgICAgICAgICAgICAgU3VwZXJjbGFzczsKICB0eXBlZGVmIFNtYXJ0
UG9pbnRlcjxTZWxmPiAgICAgICAgUG9pbnRlcjsKICB0eXBlZGVmIFNtYXJ0UG9pbnRlcjxjb25z
dCBTZWxmPiAgQ29uc3RQb2ludGVyOwoKICBpdGtOZXdNYWNybyhTZWxmKTsKCiAgdm9pZCBTZXQo
IGNvbnN0IEEgKiBhICkKICAgIHsKICAgIHRoaXMtPm1fQSA9IGE7CiAgICB9CiAKICB2b2lkIFNl
dCggY29uc3QgQyAqIGMgKQogICAgewogICAgdGhpcy0+bV9DID0gYzsKICAgIH0KcHJvdGVjdGVk
OgogIEIoKSB7IHN0ZDo6Y291dCA8PCAiQiBDb25zdHJ1Y3RvciIgPDwgc3RkOjplbmRsOyB9CiAg
dmlydHVhbCB+QigpIHsgc3RkOjpjb3V0IDw8ICJCIERlc3RydWN0b3IiIDw8IHN0ZDo6ZW5kbDsg
fQoKcHJpdmF0ZToKICBBOjpDb25zdFBvaW50ZXIgICAgICBtX0E7CiAgQzo6Q29uc3RQb2ludGVy
ICAgICAgbV9DOwp9OwoKCn0KCmludCBtYWluKCkKewppdGs6OkE6OlBvaW50ZXIgYSA9IGl0azo6
QTo6TmV3KCk7Cml0azo6Qjo6UG9pbnRlciBiID0gaXRrOjpCOjpOZXcoKTsKaXRrOjpDOjpQb2lu
dGVyIGMgPSBpdGs6OkM6Ok5ldygpOwoKLy8gTGluawpiLT5TZXQoYSk7CmItPlNldChjKTsKYy0+
U2V0KGEpOwpjLT5TZXQoYik7CgpyZXR1cm4gRVhJVF9TVUNDRVNTOwp9Cg==
--00151758f83e2a300b047543d5e5
Content-Type: text/x-c++src; charset=US-ASCII; name="SmartPointer2.cxx"
Content-Disposition: attachment; filename="SmartPointer2.cxx"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g0gnrv801
I2luY2x1ZGUgIml0a09iamVjdC5oIgojaW5jbHVkZSAiaXRrT2JqZWN0RmFjdG9yeS5oIgojaW5j
bHVkZSAiaXRrV2Vha1BvaW50ZXIuaCIKCm5hbWVzcGFjZSBpdGsKewoKY2xhc3MgQSA6IHB1Ymxp
YyBPYmplY3QKewpwdWJsaWM6CiAgdHlwZWRlZiBBICAgICAgICAgICAgICAgICAgICAgICAgIFNl
bGY7CiAgdHlwZWRlZiBPYmplY3QgICAgICAgICAgICAgICAgICAgIFN1cGVyY2xhc3M7CiAgdHlw
ZWRlZiBTbWFydFBvaW50ZXI8U2VsZj4gICAgICAgIFBvaW50ZXI7CiAgdHlwZWRlZiBTbWFydFBv
aW50ZXI8Y29uc3QgU2VsZj4gIENvbnN0UG9pbnRlcjsKCiAgaXRrTmV3TWFjcm8oU2VsZik7CnBy
b3RlY3RlZDoKICBBKCkgeyBzdGQ6OmNvdXQgPDwgIkEgQ29uc3RydWN0b3IiIDw8IHN0ZDo6ZW5k
bDsgfQogIHZpcnR1YWwgfkEoKSB7IHN0ZDo6Y291dCA8PCAiQSBEZXN0cnVjdG9yIiA8PCBzdGQ6
OmVuZGw7IH0KCnByaXZhdGU6Cn07CgoKY2xhc3MgQjsKCmNsYXNzIEMgOiBwdWJsaWMgT2JqZWN0
CnsKcHVibGljOgogIHR5cGVkZWYgQyAgICAgICAgICAgICAgICAgICAgICAgICBTZWxmOwogIHR5
cGVkZWYgT2JqZWN0ICAgICAgICAgICAgICAgICAgICBTdXBlcmNsYXNzOwogIHR5cGVkZWYgU21h
cnRQb2ludGVyPFNlbGY+ICAgICAgICBQb2ludGVyOwogIHR5cGVkZWYgU21hcnRQb2ludGVyPGNv
bnN0IFNlbGY+ICBDb25zdFBvaW50ZXI7CiAgdHlwZWRlZiBXZWFrUG9pbnRlcjxjb25zdCBTZWxm
PiAgIENvbnN0V2Vha1BvaW50ZXI7CgogIGl0a05ld01hY3JvKFNlbGYpOwoKICB2b2lkIFNldCgg
Y29uc3QgQSAqIGEgKQogICAgewogICAgdGhpcy0+bV9BID0gYTsKICAgIH0KCiAgIHZvaWQgU2V0
KCBjb25zdCBCICogYiApCiAgICB7CiAgICB0aGlzLT5tX0IgPSBiOwogICAgfQoKcHJvdGVjdGVk
OgogIEMoKSB7IHN0ZDo6Y291dCA8PCAiQyBDb25zdHJ1Y3RvciIgPDwgc3RkOjplbmRsOyB9CiAg
dmlydHVhbCB+QygpIHsgc3RkOjpjb3V0IDw8ICJDIERlc3RydWN0b3IiIDw8IHN0ZDo6ZW5kbDsg
fQoKcHJpdmF0ZToKICBBOjpDb25zdFBvaW50ZXIgICAgbV9BOwoKICB0eXBlZGVmIFNtYXJ0UG9p
bnRlcjxjb25zdCBCPiAgIEJQb2ludGVyOwogIEJQb2ludGVyICAgICAgICAgICBtX0I7Cn07CgoK
Y2xhc3MgQiA6IHB1YmxpYyBPYmplY3QKewpwdWJsaWM6CiAgdHlwZWRlZiBCICAgICAgICAgICAg
ICAgICAgICAgICAgIFNlbGY7CiAgdHlwZWRlZiBPYmplY3QgICAgICAgICAgICAgICAgICAgIFN1
cGVyY2xhc3M7CiAgdHlwZWRlZiBTbWFydFBvaW50ZXI8U2VsZj4gICAgICAgIFBvaW50ZXI7CiAg
dHlwZWRlZiBTbWFydFBvaW50ZXI8Y29uc3QgU2VsZj4gIENvbnN0UG9pbnRlcjsKCiAgaXRrTmV3
TWFjcm8oU2VsZik7CgogIHZvaWQgU2V0KCBjb25zdCBBICogYSApCiAgICB7CiAgICB0aGlzLT5t
X0EgPSBhOwogICAgfQogCiAgdm9pZCBTZXQoIGNvbnN0IEMgKiBjICkKICAgIHsKICAgIHRoaXMt
Pm1fQyA9IGM7CiAgICB9CnByb3RlY3RlZDoKICBCKCkgeyBzdGQ6OmNvdXQgPDwgIkIgQ29uc3Ry
dWN0b3IiIDw8IHN0ZDo6ZW5kbDsgfQogIHZpcnR1YWwgfkIoKSB7IHN0ZDo6Y291dCA8PCAiQiBE
ZXN0cnVjdG9yIiA8PCBzdGQ6OmVuZGw7IH0KCnByaXZhdGU6CiAgQTo6Q29uc3RQb2ludGVyICAg
ICAgbV9BOwogIEM6OkNvbnN0V2Vha1BvaW50ZXIgIG1fQzsKfTsKCgp9CgppbnQgbWFpbigpCnsK
aXRrOjpBOjpQb2ludGVyIGEgPSBpdGs6OkE6Ok5ldygpOwppdGs6OkI6OlBvaW50ZXIgYiA9IGl0
azo6Qjo6TmV3KCk7Cml0azo6Qzo6UG9pbnRlciBjID0gaXRrOjpDOjpOZXcoKTsKCi8vIExpbmsK
Yi0+U2V0KGEpOwpiLT5TZXQoYyk7CmMtPlNldChhKTsKYy0+U2V0KGIpOwoKcmV0dXJuIEVYSVRf
U1VDQ0VTUzsKfQo=
--00151758f83e2a300b047543d5e5--
More information about the Insight-users
mailing list