[Insight-users] [Insight-developers] fixing a few remaining failing tests relating to pixel-centered coordinates

[Michel Audette]

Hi Luis,

I'll get started on it.

Cheers,

Michel

On Fri, May 22, 2009 at 9:36 AM, Luis Ibanez <luis.ibanez at kitware.com>wrote:

>
> Hi Michel,
>
> You may actually find useful to write the test that Bill suggests.
> It may help solve some of the remaining failing tests.
>
> It all depends on how close you feel you are to solve the remaining
> issues.
>
>
>  Thanks,
>
>
>    Luis
>
>
> -------------------
> Michel Audette wrote:
>
>> Hi gents,
>>
>> I can certainly write a test that implements what Bill was proposing. For
>> the time being, my attention is still focused on the failing tests on the
>> Dashboard, but assuming that Luis is okay with this, we can tackle this test
>> shortly.
>>
>> Best wishes,
>>
>> Michel
>>
>> On Thu, May 21, 2009 at 9:05 AM, Wes Turner <wes.turner at kitware.com<mailto:
>> wes.turner at kitware.com>> wrote:
>>
>>    I think a warning makes sense until we have better validation.
>>    Michel/Luis is this something that fits in with what you are doing?
>>
>>    - Wes
>>
>>
>>    On Thu, May 21, 2009 at 8:37 AM, Bill Lorensen
>>    <bill.lorensen at gmail.com <mailto:bill.lorensen at gmail.com>> wrote:
>>
>>        Simon,
>>
>>        My point is that we have not validated the new code as far as I
>>        can tell.
>>
>>        Bill
>>
>>        On Thu, May 21, 2009 at 7:57 AM, Simon Warfield
>>        <simon.warfield at childrens.harvard.edu
>>        <mailto:simon.warfield at childrens.harvard.edu>> wrote:
>>         > Bill Lorensen wrote:
>>         >>
>>         >> Yes, I think that will be OK. We should add an Attention:
>>        warning to
>>         >> the CMakeLists.txt file. Something like:
>>         >>
>>         >>  SET(msg "Attention: You have chosen to enable the use of
>>         >> cell-centered coordinates.")
>>         >>
>>         >
>>         > The tool kit currently uses a mixture of both, so the above
>>        is a bit
>>         > misleading. How about instead:
>>         > SET(msg "Attention: You have chosen to enable the consistent
>>        use of centered
>>         > pixel coordinates.")
>>         >
>>         > We should explain the pros and cons of the choice e.g.:
>>         >>
>>         >>  SET(msg "${msg} This new functionality has not been fully
>>        validated.
>>         >> USE AT YOUR OWN RISK.")
>>         >>
>>         >
>>         > SET(msg "${msg} The old functionality creates an inconsistent
>>        physical
>>         > coordinate system.")
>>         >>
>>         >>  SET(msg "${msg} With this ON, you can expect to see
>>        differences in
>>         >> registration and interpolation results.")
>>         >>
>>         >
>>         > differences -> improvements
>>         >>
>>         >> # display the message during the setup
>>         >> MESSAGE("${msg}")
>>         >>
>>         >
>>         > --
>>         > Simon
>>         >>
>>         >> On Wed, May 20, 2009 at 11:23 PM, Wes Turner
>>
>


-- 
Michel Audette, Ph.D.
R & D Engineer,
Kitware Inc.,
Chapel Hill, N.C.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-users/attachments/20090522/554fa5a2/attachment.htm>