[Insight-users] Problems with itkMultiScaleHessianBasedMeasureImageFilter

Luca Antiga luca.antiga at gmail.com
Fri Dec 17 03:22:12 EST 2010 

Hi Brad,
 I guess the fact that this has been undetected highlights the need for a proper regression test. Could we use the image on the IJ paper (or a cropped version of it) for the purpose?

Luca


On Dec 16, 2010, at 1:46 PM, Bradley Lowekamp wrote:

> Hello Robert,
> 
> I apologize a gain for introducing this bug. The fix was introduced in both the ITKv4 and the release branches in the git hub. I would strongly recommend not using the master, but the release branch in git. ITKv4 is under very active development is not the place to be if you'd like stability at the moment.
> 
> Please follow the instructions under the Release section here:
> 
> http://www.itk.org/Wiki/ITK/Git/Download
> 
> I will look into getting a 3.20.1 tag or something too.
> 
> Brad
> 
> On Dec 15, 2010, at 7:28 PM, Manzke, Robert wrote:
> 
>> It works with ITK 4. 
>> 
>> Thanks for all the directions!
>> 
>> Cheers,
>> Rob
>> 
>> -----Original Message-----
>> From: Nicholas Tustison [mailto:ntustison at gmail.com] 
>> Sent: Wednesday, December 15, 2010 1:12 PM
>> To: Manzke, Robert
>> Cc: insight-users at itk.org
>> Subject: Re: [Insight-users] Problems with itkMultiScaleHessianBasedMeasureImageFilter
>> 
>> I would suspect that it's fixed in the latest itkv4.  I would just pull that file from there.
>> 
>> 
>> On Dec 15, 2010, at 1:03 PM, Manzke, Robert wrote:
>> 
>>> Hi Nick, 
>>> 
>>> Thanks, would you recommend checking the nightly itk version or smaller 3.20?
>>> 
>>> Best,
>>> Rob
>>> 
>>> -----Original Message-----
>>> From: Nicholas Tustison [mailto:ntustison at gmail.com] 
>>> Sent: Wednesday, December 15, 2010 11:29 AM
>>> To: Manzke, Robert
>>> Cc: Luca Antiga; insight-users at itk.org
>>> Subject: Re: [Insight-users] Problems with itkMultiScaleHessianBasedMeasureImageFilter
>>> 
>>> Hi Robert,
>>> 
>>> I remember having a similar issue and later it was discovered that somebody, I believe it was Brad Lowenkamp, had made some changes which he later corrected.  Perhaps your current configuration doesn't reflect this correction.
>>> 
>>> Nick
>>> 
>>> 
>>> On Dec 15, 2010, at 11:14 AM, Manzke, Robert wrote:
>>> 
>>>> Hi Luca, 
>>>> 
>>>> I successfully compiled and ran your original submission code, works fine, image results are correct.
>>>> 
>>>> However, the code in the itk 3.20 review directory for
>>>> 
>>>> itkMultiScaleHessianBasedMeasureImageFilter
>>>> 
>>>> including the tests does not seem to work.
>>>> 
>>>> Is anyone aware of this?
>>>> 
>>>> Thanks a lot!
>>>> Rob
>>>> 
>>>> -----Original Message-----
>>>> From: Luca Antiga [mailto:luca.antiga at gmail.com] 
>>>> Sent: Tuesday, December 14, 2010 5:01 PM
>>>> To: Manzke, Robert
>>>> Cc: insight-users at itk.org
>>>> Subject: Re: [Insight-users] Can't get itkMultiScaleHessianBasedMeasureImageFilter to work
>>>> 
>>>> Hi Robert,
>>>> the code from the submission compiles for me. 
>>>> 
>>>> In your case it looks like you just compiled the file I sent, while you should compile the whole source directory (http://www.insight-journal.org/browse/publication/175). The reason for this is that, as you figured out, the code has undergone some refactoring while moving into ITK Review.
>>>> 
>>>> However, if you did that already, it might be that your compiler sees the files in Review first instead of the ones in the source code directory (some of which have the same name), in which case I suggest you compile the code against a version of ITK configured with USE_REVIEW=OFF in CMake. This way you'll run no risk of collisions.
>>>> 
>>>> Let me know if you can get the code to compile.
>>>> 
>>>> Best regards
>>>> 
>>>> Luca
>>>> 
>>>> 
>>>> On Dec 14, 2010, at 2:49 PM, Manzke, Robert wrote:
>>>> 
>>>>> Hi Luca,
>>>>> 
>>>>> thanks for getting back!
>>>>> 
>>>>> I have tried compiling your original code with 3.20 which didn't work (attached the build log).
>>>>> Then I have compiled the test files which comes with 3.20 itkMultiScaleHessianBasedMeasureImageFilterTest.cxx (attached and slightly modified for .png output), which does compile but produces junk output images (attached, I used same parameters as you used for your example).
>>>>> 
>>>>> The code in the test is pretty different from your original code, so I guess that things were modified/adapted when it was included in ITK..?
>>>>> 
>>>>> I have no idea how to get it working, do you have any insights?
>>>>> 
>>>>> Thanks so much
>>>>> Rob
>>>>> ________________________________________
>>>>> From: Luca Antiga [luca.antiga at gmail.com]
>>>>> Sent: Monday, December 13, 2010 16:36
>>>>> To: Manzke, Robert
>>>>> Cc: insight-users at itk.org
>>>>> Subject: Re: [Insight-users] Can't get  itkMultiScaleHessianBasedMeasureImageFilter to work
>>>>> 
>>>>> Hi Robert,
>>>>> not sure what's going on in your case.
>>>>> Please find attached a slightly modified version of the example in my IJ paper that saves to png. I attach what I just got  on my MacOS 10.6, using an ITK 3.20 build. I'm referring to the IJ paper since I see your code is based on those classes.
>>>>> 
>>>>> Can you please check that by replacing the attached file in my submission, building and running
>>>>> ./MultiScaleObjectnessExample2D DSA.png DSA_out.png DSA_scales.png 1.0 10.0 10 1
>>>>> you're getting the same output as the image in attachment?
>>>>> 
>>>>> Thanks for your feedback
>>>>> 
>>>>> Luca
>>>>> 
>>>>> 
>>>>> 
>>>>> The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.
>>>>> <buildlog.txt><itkMultiScaleHessianBasedMeasureImageFilterTest_modified.cxx><DSA_out.png><DSA_out2.png><DSA_scales.png><DSA_scales2.png>
>>>> 
>>>> 
>>>> _____________________________________
>>>> Powered by www.kitware.com
>>>> 
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>> 
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://www.kitware.com/products/protraining.html
>>>> 
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>> 
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-users
>>> 
>>> 
>>> _____________________________________
>>> Powered by www.kitware.com
>>> 
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>> 
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://www.kitware.com/products/protraining.html
>>> 
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>> 
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-users
>> 
>> 
>> _____________________________________
>> Powered by www.kitware.com
>> 
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>> 
>> Kitware offers ITK Training Courses, for more information visit:
>> http://www.kitware.com/products/protraining.html
>> 
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>> 
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-users
> 
> _____________________________________
> Powered by www.kitware.com
> 
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> 
> Kitware offers ITK Training Courses, for more information visit:
> http://www.kitware.com/products/protraining.html
> 
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
> 
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-users

More information about the Insight-users mailing list