[Insight-users] Patch for gcc 4.7 from ITK 3.20.1

[Matt McCormick]

Hi Marta,

Thank you very much for you patch.  I tried to apply it, but all the
changes appear to be in the previous patch created by Vivien.  Please
try this:

git clone http://itk.org/ITK.git
./Utilities/SetupForDevelopment.sh
git checkout -b release-3.20 origin/release-3.20
git checkout -b gcc4.7fixes
<make your changes and test them>
git commit -a
git format-patch HEAD^

Thanks,
Matt

On Thu, Apr 26, 2012 at 5:34 AM, Marta Peroni <m.peroni at gmail.com> wrote:
> Thank you Matt!
>
> Sorry for the delay (was holiday in italy :P)...in attachment the patch
> derived from my folders. Please let me know if it is ok, because it is my
> first patch ever :)
>
> thanks
> Marta
>
>
> On 24 April 2012 21:17, Matt McCormick <matt.mccormick at kitware.com> wrote:
>>
>> Hi Marta,
>>
>> Normally, most patches can be submitted easily by anyone through our
>> Gerrit system.  However, since we have not set up Gerrit support for
>> the release-3.20 branch yet, please reply to this thread with the
>> patch as an attachment (using git format-patch), and I will start the
>> branch with these patches.
>>
>> Thanks,
>> Matt
>>
>> On Tue, Apr 24, 2012 at 10:28 AM, Marta Peroni <m.peroni at gmail.com> wrote:
>> > Thanks Vivien!
>> > Do I require any special permission to submit the patch? like login/pwd
>> > and
>> > so on...
>> >
>> > So if I understand correctly, you are basically running my same exact
>> > configuration and did not have problems with those 3 files?
>> > strange :S
>> >
>> > thanks
>> > Marta
>> >
>> >
>> > On 24 April 2012 11:11, Vivien Delmon
>> > <vivien.delmon at creatis.insa-lyon.fr>
>> > wrote:
>> >>
>> >> On 04/24/2012 10:15 AM, Marta Peroni wrote:
>> >>>
>> >>> Hi!
>> >>
>> >>
>> >> Hi,
>> >>
>> >>
>> >>> I had same issue with ITK3.20 and therefore tried the patch submitted
>> >>> to
>> >>> this list...but, this was not enough...
>> >>>
>> >>> I'm running on arch linux, gcc 4.7, build with review on and use
>> >>> optimized methods on.
>> >>
>> >>
>> >> I am also running ArchLinux with gcc 4.7 ITK_REVIEW and
>> >> ITK_USE_OPTIMIZED_REGISTRATION_METHODS. I should try to turn all flag
>> >> on to
>> >> track all gcc issues.
>> >>
>> >>
>> >>> I additionally had to change the following files:
>> >>> * vnl_matrix_fixed_ref.h
>> >>> * itkParametricPath.txx
>> >>> * itkMRCImageIO.h
>> >>>
>> >>> Anyone interested in the details/ how should I submit the patch?
>> >>
>> >>
>> >> To create a patch I did :
>> >> git co v3.20.1
>> >> git add ...
>> >> git commit
>> >> git format-patch v3.20.1
>> >>
>> >>
>> >>> I wonder also...does ITK4 compiles with gcc4.7?
>> >>> I personally need 3.20, but would be good to know I guess...
>> >>
>> >>
>> >> I use ITK4 (git release branch) and I have no problem building it.
>> >>
>> >>> thanks
>> >>> Marta
>> >>
>> >>
>> >> --
>> >> Vivien Delmon
>> >> PhD student at CREATIS, Lyon
>> >> Supported by ANRT and ELEKTA
>> >> http://www.creatis.insa-lyon.fr/rio
>> >>
>> >> _____________________________________
>> >> Powered by www.kitware.com
>> >>
>> >> Visit other Kitware open-source projects at
>> >> http://www.kitware.com/opensource/opensource.html
>> >>
>> >> Kitware offers ITK Training Courses, for more information visit:
>> >> http://www.kitware.com/products/protraining.php
>> >>
>> >> Please keep messages on-topic and check the ITK FAQ at:
>> >> http://www.itk.org/Wiki/ITK_FAQ
>> >>
>> >> Follow this link to subscribe/unsubscribe:
>> >> http://www.itk.org/mailman/listinfo/insight-users
>> >
>> >
>> >
>> > _____________________________________
>> > Powered by www.kitware.com
>> >
>> > Visit other Kitware open-source projects at
>> > http://www.kitware.com/opensource/opensource.html
>> >
>> > Kitware offers ITK Training Courses, for more information visit:
>> > http://www.kitware.com/products/protraining.php
>> >
>> > Please keep messages on-topic and check the ITK FAQ at:
>> > http://www.itk.org/Wiki/ITK_FAQ
>> >
>> > Follow this link to subscribe/unsubscribe:
>> > http://www.itk.org/mailman/listinfo/insight-users
>> >
>
>