[Insight-users] Override SetFixedImageRegion() in itk::ImageToImageMetric

[Matt McCormick]

Hi Sureerat,

Looks great!  The "Add Reviewer" button should show up in the Gerrit web
page if you are logged in.  Attached is a screenshot.

Thanks,
Matt


On Thu, Aug 15, 2013 at 5:25 PM, Sureerat Reaungamornrat <
sureerat.r at gmail.com> wrote:

> Dear Matt,
>
>    I have submitted the patch but I somehow could not add reviewer.
> I am not familiar with GIT, so I wonder whether I have done something
> wrong.
>
>    The url is  http://review.source.kitware.com/12307    and there is no
> 'Add Reviewer' button there.
>
> Thank you very much,
>
> Best regards,
>
> Sureerat
>
>
>
>
> On Mon, Jul 22, 2013 at 11:20 AM, Matt McCormick <
> matt.mccormick at kitware.com> wrote:
>
>> Hi Sureerat,
>>
>> The v4 RegistrationMethods have a more flexible image domain
>> specification framework -- creating new methods of the v4 versions may
>> be able to perform as you would like.
>>
>> However, if you are using ImageRegistrationMethod and need that method
>> virtual, you are encouraged to submit a patch as explained here:
>>
>>
>> http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftwareProcess/SubmitAPatchToGerrit/index.html
>>
>> Thanks,
>> Matt
>>
>> On Mon, Jul 22, 2013 at 2:43 PM, Sureerat Reaungamornrat
>> <sureerat.r at gmail.com> wrote:
>> > Dear ITK,
>> >
>> >    I have using ITK to develop and learn image registration. Currently,
>> > I am trying to incorporate penalty term into B-spline registration. I
>> create
>> > a class (called itk::ImageToImageMultiMetric) derived from
>> > itk::ImageToImageMetric
>> > to add the normal similarity metric (like MSE or MI) and the penalty
>> term.
>> > I need to override some functions in itk::ImageToImageMetric. Nearly
>> all of
>> > the
>> > functions can  be overriden except SetFixedImageRegion(). I currently
>> just
>> > work around it.
>> > I wonder whether it is possible to make the function 'virtual' so I can
>> > easily override it
>> > and reduce the current complicated work-around.
>> >
>> > Thank you very much,
>> >
>> > Best regards,
>> >
>> > Sureerat
>> >
>> > _____________________________________
>> > Powered by www.kitware.com
>> >
>> > Visit other Kitware open-source projects at
>> > http://www.kitware.com/opensource/opensource.html
>> >
>> > Kitware offers ITK Training Courses, for more information visit:
>> > http://www.kitware.com/products/protraining.php
>> >
>> > Please keep messages on-topic and check the ITK FAQ at:
>> > http://www.itk.org/Wiki/ITK_FAQ
>> >
>> > Follow this link to subscribe/unsubscribe:
>> > http://www.itk.org/mailman/listinfo/insight-users
>> >
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-users/attachments/20130815/9b053131/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_reviewer.png
Type: image/png
Size: 5717 bytes
Desc: not available
URL: <http://www.itk.org/pipermail/insight-users/attachments/20130815/9b053131/attachment.png>