[Insight-users] elongation implementation not matching its definition

[Matt McCormick]

Hi Cagatay,

You are correct.  Would you like to submit a patch that updates the
documentation?  This can be done through the source tree as described
here:

  http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftwareProcess/SubmitAPatchToGerrit/index.html

or through the "Edit Comments" link in the Doxygen HTML.

Thanks,
Matt

On Thu, Aug 22, 2013 at 9:13 PM, Cagatay Bilgin <bilgincc at gmail.com> wrote:
> Hello everyone,
>
> Either I am missing something or the write up about the elongation is not
> matching the actual implementation.
>
> "elongation is computed as the ratio of the largest principal moment by the
> smallest principal moment. "
>
> however in itkShapeLabelMapFilter.hxx elongation is defined as largest
> principal moment / second largest principal moment. In 3D the definition and
> the implementation becomes inconsistent.
>
> from itkShapeLabelMapFilter.hxx
> 331  elongation = vcl_sqrt(principalMoments[ImageDimension - 1] /
> principalMoments[ImageDimension - 2]);
> 332  flatness = vcl_sqrt(principalMoments[1] / principalMoments[0]);
>
> Cheers,
> C. Cagatay Bilgin
>
> --
> Cemal Cagatay Bilgin, PhD
> Life Sciences Division
> Lawrence Berkeley National Lab
> MS977, One Cyclotron Road
> Berkeley, CA 94720, USA
> Email: ccbilgin at lbl.gov
>
> _____________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://www.kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-users
>