[ITK-users] Segfault in Wiki Example: QuadEdgeMeshParameterizationFilter

[Matt McCormick]

Excellent, yes! You should be able to push directly.

On Fri, Jun 12, 2015 at 10:03 AM, Davis Vigneault
<davis.vigneault at gmail.com> wrote:
> Thanks very much, Matt!
>
> I've just pushed the changes (in the normal git way, not using
> gerrit-push--I hope that's what I was meant to do).
>
> Best, and thanks,
>
> --Davis
>
> On Fri, Jun 12, 2015 at 2:31 PM, Matt McCormick <matt.mccormick at kitware.com>
> wrote:
>>
>> Hi Davis,
>>
>> Sorry -- the misunderstanding was on my part :-).  Here is the
>> WalkInTriagulation repository then:
>>
>>   https://github.com/InsightSoftwareConsortium/ITKWalkInTriangulation
>>
>> Thanks!
>> Matt
>>
>> On Fri, Jun 12, 2015 at 9:26 AM, Davis Vigneault
>> <davis.vigneault at gmail.com> wrote:
>> > Matt--
>> >
>> > The changes I had were actually for the WalkInTriangulation example [1].
>> > Did you mean to fork that instead of itkVoroniQuadEdgeMeshFilter?  In
>> > that
>> > fork, the OrientationTest function missing from the IJ submission seems
>> > to
>> > have been refactored as the Orientation2DFunction class [2].  (Please
>> > let me
>> > know if I've misunderstood what you intended.)
>> >
>> > Best, and thanks!
>> >
>> > --Davis
>> >
>> > [1] https://github.com/midas-journal/midas-journal-851
>> > [2]
>> >
>> > https://github.com/ComplexSystemsModeling/itkVoronoiQuadEdgeMeshFilter/blob/master/Modules/Predicates/include/itkOrientation2DFunction.h
>> >
>> > On Fri, Jun 12, 2015 at 1:37 PM, Matt McCormick
>> > <matt.mccormick at kitware.com>
>> > wrote:
>> >>
>> >> Hi Davis, Arnaud,
>> >>
>> >> I have forked the repositories to:
>> >>
>> >>
>> >>
>> >> https://github.com/InsightSoftwareConsortium/itkVoronoiQuadEdgeMeshFilter
>> >>   https://github.com/InsightSoftwareConsortium/ITKPointInCircle
>> >>
>> >> if you want to develop there.
>> >>
>> >> HTH,
>> >> Matt
>> >>
>> >> On Fri, Jun 12, 2015 at 7:54 AM, Arnaud Gelas <arnaudgelas at gmail.com>
>> >> wrote:
>> >> > Hi Davis,
>> >> >
>> >> > Could you make pull requests to fix this code, please?
>> >> >
>> >> > Not sure who can accept pull request for midas-journal account though
>> >> > :-/…
>> >> > If that’s not easily doable, we could import these contributions in
>> >> > the
>> >> > InsightSoftwareConsortium’s organization.
>> >> >
>> >> > Best
>> >> > Arnaud
>> >> >
>> >> >> On 10 Jun 2015, at 15:05, DVigneault <davis.vigneault at gmail.com>
>> >> >> wrote:
>> >> >>
>> >> >> Arnaud--
>> >> >>
>> >> >> Thank you for your help, and for the link to the Insight article!  I
>> >> >> was
>> >> >> able to compile and use the Point In Circle [1] example without
>> >> >> difficulty.
>> >> >> I had a little more trouble with the Straight Walk [2] example.
>> >> >> I've
>> >> >> written reviews for both on IJ.  I've reproduced below the part of
>> >> >> the
>> >> >> review describing the steps I needed to take to get the Straight
>> >> >> Walk
>> >> >> example working.
>> >> >>
>> >> >> 1.  It appears that the submodule is not linked correctly in github.
>> >> >> I
>> >> >> needed to remove the .gitmodules file and add the submodule
>> >> >> manually.
>> >> >> Here
>> >> >> is my StackOverflow question [3] which solved the problem.
>> >> >> 2.  I had to change WalkInTriangulation/CMakeLists.txt:6:
>> >> >> include( ${USE_ITK_FILE}) ==> include( ${ITK_USE_FILE})
>> >> >> 3.  At this point, CMake runs without errors; but when building I'm
>> >> >> told
>> >> >> that OrientationTest is missing.  I assumed that OrientationTest is
>> >> >> a
>> >> >> wrapper for orient2d, and added the following function to
>> >> >> itkWalkInTriangulationFunction.h:
>> >> >>
>> >> >> template< typename TPoint >
>> >> >> double
>> >> >> OrientationTest( TPoint a, TPoint b, TPoint c )
>> >> >> {
>> >> >>  double pa[2];
>> >> >>  double pb[2];
>> >> >>  double pc[2];
>> >> >>
>> >> >>  pa[0] = a[0];
>> >> >>  pa[1] = a[1];
>> >> >>
>> >> >>  pb[0] = b[0];
>> >> >>  pb[1] = b[1];
>> >> >>
>> >> >>  pc[0] = c[0];
>> >> >>  pc[1] = c[1];
>> >> >>
>> >> >>  return orient2d(pa, pb, pc);
>> >> >>
>> >> >> }
>> >> >>
>> >> >> With those changes, the example seems to work correctly, though I
>> >> >> haven't
>> >> >> done thorough testing yet.
>> >> >>
>> >> >> Best, and thanks again,
>> >> >>
>> >> >> --Davis
>> >> >>
>> >> >> [1] https://github.com/midas-journal/midas-journal-843
>> >> >> [2] https://github.com/midas-journal/midas-journal-851
>> >> >> [3]
>> >> >>
>> >> >>
>> >> >> http://stackoverflow.com/questions/30754878/recursively-cloning-a-git-repo-doesnt-pull-submodules/30756107#30756107
>> >> >>
>> >> >>
>> >> >>
>> >> >> --
>> >> >> View this message in context:
>> >> >>
>> >> >> http://itk-insight-users.2283740.n2.nabble.com/ITK-users-Segfault-in-Wiki-Example-QuadEdgeMeshParameterizationFilter-tp7587442p7587463.html
>> >> >> Sent from the ITK Insight Users mailing list archive at Nabble.com.
>> >> >> _____________________________________
>> >> >> Powered by www.kitware.com
>> >> >>
>> >> >> Visit other Kitware open-source projects at
>> >> >> http://www.kitware.com/opensource/opensource.html
>> >> >>
>> >> >> Kitware offers ITK Training Courses, for more information visit:
>> >> >> http://www.kitware.com/products/protraining.php
>> >> >>
>> >> >> Please keep messages on-topic and check the ITK FAQ at:
>> >> >> http://www.itk.org/Wiki/ITK_FAQ
>> >> >>
>> >> >> Follow this link to subscribe/unsubscribe:
>> >> >> http://public.kitware.com/mailman/listinfo/insight-users
>> >> >
>> >> > _____________________________________
>> >> > Powered by www.kitware.com
>> >> >
>> >> > Visit other Kitware open-source projects at
>> >> > http://www.kitware.com/opensource/opensource.html
>> >> >
>> >> > Kitware offers ITK Training Courses, for more information visit:
>> >> > http://www.kitware.com/products/protraining.php
>> >> >
>> >> > Please keep messages on-topic and check the ITK FAQ at:
>> >> > http://www.itk.org/Wiki/ITK_FAQ
>> >> >
>> >> > Follow this link to subscribe/unsubscribe:
>> >> > http://public.kitware.com/mailman/listinfo/insight-users
>> >
>> >
>
>