[Insight-developers] can't push on gerrit ?

[Arnaud GELAS]

Seems to be fixed now!?

Thanks for fixing it!!!


On 04/22/2011 02:36 PM, Arnaud GELAS wrote:
> On 04/22/2011 02:27 PM, Marcus D. Hanwell wrote:
>> On Fri, Apr 22, 2011 at 1:25 PM, Arnaud GELAS
>> <arnaud_gelas at hms.harvard.edu>   wrote:
>>> Hi all,
>>>
>>> I am trying to push a patch on gerrit, but I can't...
>>>
>>> $ git gerrit-push
>>> Counting objects: 81, done.
>>> Delta compression using up to 12 threads.
>>> Compressing objects: 100% (50/50), done.
>>> Writing objects: 100% (50/50), 20.60 KiB, done.
>>> Total 50 (delta 34), reused 0 (delta 0)
>>> To arnaudgelas at review.source.kitware.com:ITK
>>>    ! [remote rejected] HEAD ->
>>> refs/for/master/Relocate_LabelContourImageFilter (missing Change-Id in
>>> commit message )
>>> error: failed to push some refs to
>>> 'arnaudgelas at review.source.kitware.com:ITK'
>>>
>>>
>>>
>>> here is my commit message
>>>
>>> $ git log
>>> commit 3ee05d45f48e3bfee26c07a3f3f140596c977a95
>>> Author: Arnaud Gelas<arnaud_gelas at hms.harvard.edu>
>>> Date:   Fri Apr 22 13:17:06 2011 -0400
>>>
>>>      ENH: Relocate LabelContourImageFilter into ITK-ImageLabel module
>>>
>>>      This filter was in ITK-Review
>>>
>>>      Change-Id: I4e67404a5d51e7593c0a2635f87716fa31ee6528
>>>
>>>
>>>
>>> I have tried rewinding back 100 commits, clearing, pulling again from
>>> master, creating a new branch and applying the patch, but still the same
>>> thing...
>>>
>>> Any idea what is going wrong? and how I can solve it?
>>>
>> I had turned on the Gerrit requirement for commits to contain
>> Change-Id. If you check
>>
>> git log gerrit/master..
>>
>> Do you only see your commits? I turned the check off for now, but I am
>> wondering if the robot has stopped pushing new ITK commits into
>> Gerrit's master, or something like that.
>>
>> Marcus
> I can see commits from 01be852fabc6f3061c63b2a71e3250007f9f0f73 to my
> last one I wanted to submit on gerrit
>
> which was merged this morning, but still shows up on gerrit:
>
>       http://review.source.kitware.com/#change,1457
>
> I have just tried pushing my changes, it worked! But several patches
> already merged have now appeared on gerrit:
>
>       http://review.source.kitware.com/#change,1478
>       http://review.source.kitware.com/#change,1477
>       http://review.source.kitware.com/#change,1476
>
> What should I do?
>
> Thanks,
> Arnaudz
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers