[Insight-developers] [slicer-devel] ITK 3 tag to use with slicer? Fwd: Slicer release schedule

Sun Jul 17 08:56:48 EDT 2011

Seems like we should move all changes from Slicer-ITK into ITK3.20?
https://github.com/Slicer/ITK/commits/slicer-4.0

We cannot cherry-pick if we want this to be the release used with Slicer.

s

On Sun, Jul 17, 2011 at 8:46 AM, Andras Lasso <lasso at cs.queensu.ca> wrote:
> Hi Bill,
>
> This one would also quite important (necessary for slice-to-volume
> registration Slicer): http://www.itk.org/Bug/view.php?id=11699. You merged
> the fix into ITK4 in January (http://review.source.kitware.com/#change,729)
> but it's not in ITK-3.20.
>
> Andras
>
> -----Original Message-----
> From: slicer-devel-bounces at bwh.harvard.edu
> [mailto:slicer-devel-bounces at bwh.harvard.edu] On Behalf Of Bill Lorensen
> Sent: 2011-July-16 5:01 PM
> To: Johnson, Hans J
> Cc: Slicer Development; ITK
> Subject: Re: [slicer-devel] [Insight-developers] ITK 3 tag to use with
> slicer? Fwd: Slicer release schedule
>
> Steve (and all),
>
> Are there other [atches to the Slicer ITK 3.20 clone that we should
> also look at for inclusion in the official 3.20 branch?
>
> Bill
>
> On Sat, Jul 16, 2011 at 4:57 PM, Johnson, Hans J <hans-johnson at uiowa.edu>
> wrote:
>> I already have the patches.  It's only 3 lines of code. I was going to
>> work on it tomorrow and post to gerrit.
>>
>> I'm currently trying to find a gcc 4.6 system to test with.
>>
>>
>> Hans
>>
>>
>> On 7/16/11 3:44 PM, "Bill Lorensen" <bill.lorensen at gmail.com> wrote:
>>
>>>JC,
>>>
>>>If you provide a git patchs we can apply it to the itk 3.20 release.
>>>
>>>Using:
>>>git format-patch -M
>>>
>>>Bill
>>>
>>>On Thu, Jul 14, 2011 at 5:09 PM, Jean-Christophe Fillion-Robin
>>><jchris.fillionr at kitware.com> wrote:
>>>> Hi Folks,
>>>>
>>>> Looking at the history of Slicer/ITK branch "slicer-4.0", you will
>>>>notice
>>>> that commits have integrated so that it compiles:
>>>>
>>>>   1) on 64bits windows
>>>>
>>>> Merge branch 'fix-vnl-64bits-compile' into slicer-4.0
>>>>
>>>> * fix-vnl-64bits-compile:
>>>>   Review DETERMINE_TYPE vxl macro
>>>>   Add VXL_SIZEOF_SIZE_T test
>>>>   Add VXL_HAS_WIN_WCHAR_T test
>>>>
>>>>
>>>>   Update VXL_HAS_TYPE_OF_SIZE test
>>>>
>>>> See
>>>>
>>>>https://github.com/Slicer/ITK/commit/71e4277a785ae0f14c5c1cd2a8df1a70d99f
>>>>1052
>>>>
>>>>   2) on unix-like system using gcc-4.6
>>>>
>>>> Merge branch 'fix-gcc46-compile' into slicer-4.0
>>>>
>>>> * fix-gcc46-compile:
>>>>   COMP: Add missing include <stddef.h> for ptrdiff_t
>>>>   COMP: Add missing include <stddef.h> for ptrdiff_t
>>>>
>>>> See
>>>>
>>>>https://github.com/Slicer/ITK/commit/309a4221146ee34ee87cd4a3fc0cae26bd75
>>>>35c4
>>>>
>>>>
>>>> It shouldn't be to hard to patch the version of ITK your are currently
>>>>using
>>>> for Slicer3.
>>>>
>>>> Any question, please let me know.
>>>> Thanks
>>>> Jc
>>>>
>>>>
>>>> On Thu, Jul 14, 2011 at 4:05 PM, Stephen Aylward
>>>> <stephen.aylward at kitware.com> wrote:
>>>>>
>>>>> Hi Steve,
>>>>>
>>>>> I am CC'ing J2 and JC.
>>>>>
>>>>> JC, in particular, did a huge amount of work to get ITK-Slicer to
>>>>> compile for 64bits.  We should not change versions without involving
>>>>> him.
>>>>>
>>>>> s
>>>>>
>>>>> On Thu, Jul 14, 2011 at 1:57 PM, Steve Pieper <pieper at ibility.net>
>>>>>wrote:
>>>>> > Hi Hans, Bill, Stephen Luis -
>>>>> >
>>>>> > Is there a version of ITK 3 that compiles on the gcc-4.6 compiler?
>>>>>I'm
>>>>> > not
>>>>> > on the itk-devel list so I can't follow the link in Dominique's
>>>>>email,
>>>>> > but I
>>>>> > guess there's been some discussion of it.  (Bill - this is the
>>>>>question
>>>>> > I
>>>>> > mentioned the other day on the phone).
>>>>> >
>>>>> > What I'm looking for is a version of ITK to make the default for the
>>>>> > current
>>>>> > slicer3 trunk so that it will build on the latest compilers.  Also
>>>>>we'll
>>>>> > want to use that version for slicer4 currently, with the ideas that
>>>>> > we'll
>>>>> > eventually want to swap over to ITK 4.x when it settles down.
>>>>> >
>>>>> > Thanks,
>>>>> > Steve
>>>>> >
>>>>> >
>>>>> > ---------- Forwarded message ----------
>>>>> > From: Dominique Belhachemi <domibel at debian.org>
>>>>> > Date: Thu, Jul 14, 2011 at 11:31 AM
>>>>> > Subject: Re: Slicer release schedule
>>>>> > To: pieper at bwh.harvard.edu
>>>>> > Cc: Ron Kikinis <kikinis at bwh.harvard.edu>
>>>>> >
>>>>> >
>>>>> > Hi Steve,
>>>>> >
>>>>> > I asked in May if they can do a new patch release. They patched their
>>>>> > git release branch and I am waiting now...
>>>>> >
>>>>> >
>>>>>http://www.itk.org/mailman/private/insight-developers/2011-May/018475.ht
>>>>>ml
>>>>> >
>>>>> > BTW, This doesn't affect the Debian packages, it only affects people
>>>>> > who compile Slicer3 from scratch on a Linux box with the current
>>>>> > gcc-4.6 compiler.
>>>>> >
>>>>> > Thanks
>>>>> > Dominique
>>>>> >
>>>>> >
>>>>> > On Wed, Jul 13, 2011 at 5:15 PM, Steve Pieper <pieper at ibility.net>
>>>>> > wrote:
>>>>> >>
>>>>> >> On Sun, Jul 10, 2011 at 7:18 PM, Dominique Belhachemi
>>>>> >> <domibel at debian.org>
>>>>> >>> ITK looks good. There are basically no changes to ITK 3.x. But for
>>>>>the
>>>>> >>> current Slicer3 release you have to ask for a new tag. Otherwise
>>>>>user
>>>>> >>> will run into gcc-4.6 compilation issues.
>>>>> >>>
>>>>> >>
>>>>> >> For packaging we should be able to use the 3.20 release (I don't
>>>>>recall
>>>>> >> the
>>>>> >> version issues - does 3.20 build on gcc 4.6?).  Or if that's the one
>>>>> >> that
>>>>> >> fails we can probably twist their arms to make a 3.22 version with
>>>>>the
>>>>> >> fix
>>>>> >> for everyone.
>>>>> >>
>>>>> >
>>>>> >
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> ==============================
>>>>> Stephen R. Aylward, Ph.D.
>>>>> Director of Medical Imaging Research
>>>>> Kitware, Inc. - North Carolina Office
>>>>> http://www.kitware.com
>>>>> stephen.aylward (Skype)
>>>>> (919) 969-6990 x300
>>>>
>>>>
>>>>
>>>> --
>>>> +1 919 869 8849
>>>>
>>>>
>>>_______________________________________________
>>>Powered by www.kitware.com
>>>
>>>Visit other Kitware open-source projects at
>>>http://www.kitware.com/opensource/opensource.html
>>>
>>>Kitware offers ITK Training Courses, for more information visit:
>>>http://kitware.com/products/protraining.html
>>>
>>>Please keep messages on-topic and check the ITK FAQ at:
>>>http://www.itk.org/Wiki/ITK_FAQ
>>>
>>>Follow this link to subscribe/unsubscribe:
>>>http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>>
>> ________________________________
>> Notice: This UI Health Care e-mail (including attachments) is covered by
> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
> confidential and may be legally privileged.  If you are not the intended
> recipient, you are hereby notified that any retention, dissemination,
> distribution, or copying of this communication is strictly prohibited.
>  Please reply to the sender that you have received the message in error,
> then delete it.  Thank you.
>> ________________________________
>>
> _______________________________________________
> slicer-devel mailing list
> slicer-devel at bwh.harvard.edu
> http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel
> To unsubscribe: send email to slicer-devel-request at massmail.spl.harvard.edu
> with unsubscribe as the subject
>
>
> _______________________________________________
> slicer-devel mailing list
> slicer-devel at bwh.harvard.edu
> http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel
> To unsubscribe: send email to slicer-devel-request at massmail.spl.harvard.edu with unsubscribe as the subject
>

-- 

==============================
Stephen R. Aylward, Ph.D.
Director of Medical Imaging Research
Kitware, Inc. - North Carolina Office
http://www.kitware.com
stephen.aylward (Skype)
(919) 969-6990 x300