[Insight-developers] SimpleITK Alpha01 tagged

[Dan Mueller]

Hi Brad,

Thanks for responding. See my comments inline below.

On 21 June 2011 05:40, Bradley Lowekamp <blowekamp at mail.nih.gov> wrote:
> Hello,
>
> On Jun 20, 2011, at 2:11 PM, Dan Mueller wrote:
>
>> Hi Brad,
>>
>> I have been playing around with SimpleITK. My initial thought is:
>> nice! For me the most noticeable aspect is the simplification
>> surrounding pixel types.
>>
>> However, there are a few (important) things I miss:
>>
>> 1. I could not find a way to import/export pixel data (i.e. there is
>> no ImportImageFilter and no access to the pixel buffer/container). (I
>> did find Examples/ImageConnection.java, but I don't see how it can
>> work -- I can't find Image::GetPixelContainer. Is this example/test
>> passing?).
>
> The ability to import and export the pixel container, hasn't been implemented yet. We went through a couple iterations of an aux PixelContainer class, before changing the design. The current plan is to add an ImportImageFilter to the IO directory, and to add a read-only GetPixelBufferAs#(SpecificPixelType)# method in the Image class. Where the GetPixelBufferAs is similar to the current set GetPixelMethods.
>
> So no. The example is incorrect. There is a topic some where on github that needs to be revived from the dead which contains some of these needed classes
>
>>
>> 2. ImageFileReader needs Get/SetInputPixelType, and ImageFileWriter
>> needs Get/SetOutputPixelType (similar to CastImageFilter).
>
> I am not sure I understand this need.
>
> What's wrong with:
>
> #include "SimpleITK.h"
> namespace sitk = itk::simple;
>
> sitk::Image image = sitk::Cast( sitk::ReadImage( fname ), sitk::UInt16 );
>
> The SimpleITK file reader automatically detect the type of image in the file, and loads it as such. Then instead of specifying the type the image is converted to as a template to an ImageFileRead, you specify it as an enum to a CastImageFIlter. It really looks like the same difference to me.

Fair enough -- the cast can be done after the read / before the write.

>> 3. Coverage needs to be improved. I am missing distance map, fast
>> marching, various image grid filters (resample, pad, orient),
>> (quad)mesh, etc.
>
> Yes, many of the grid should be fairly easy to implement, or are in the process of being implemented. There are many ImageFilters in ITK, and everyone has their favorites, or ones that are required.
>
> I created a WIki page to help in providing user feedback for the "must have" ITK filter:
>
> http://www.itk.org/Wiki/ITK_Release_4/SimpleITK/Filters#Must_Implement_Filters_for_SimpleITK
>
> Please add your "must haves" there.
>
> Currently, we are focussing on making SimpleITK robust for images and related processing. I am not sure when QuadEdgeMeshes will come into scope.

Thanks for creating the page. Done.

>> 4. I am still an advocate of the strategy pattern, though obviously
>> I'm very biased :P
>>    http://www.insight-journal.org/browse/publication/786
>
> As the code generation tool was developed it became clear that the strategy pattern was going to be a more manual process, then 1:1 filter code generation.
>
> However, the registration framework will likely but a much more manual process, and we have been considering this pattern for a couple of situations.
>
>>
>> If I can find the time, I'll try to push a few changesets addressing these gaps.
>>
>> Cheers, Dan (Mueller)
>>
>> On 20 June 2011 15:49, Bradley Lowekamp <blowekamp at mail.nih.gov> wrote:
>>> Hello all,
>>> I'd just like to share that we SimpleITK development team tagged the Alpha 1
>>> release yesterday as "va01". If you have been interested in SimpleITK, this
>>> may be a good opportunity to download it and give it a try.
>>> Brad
>>>
>>> ========================================================
>>>
>>> Bradley Lowekamp
>>>
>>> Lockheed Martin Contractor for
>>>
>>> Office of High Performance Computing and Communications
>>>
>>> National Library of Medicine
>>>
>>> blowekamp at mail.nih.gov
>>>
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>
>