[Insight-developers] Change in ITK[master]: BUG: Add test for MetaIO vessel tube from getting stuck in w...

[Bill Lorensen]

We really should not be committing patches that are expected to fail.
The metaio fix should have been done first.

We don't want folks ignoring the dashboard because it is always red.

But, thanks for staying on top of this.

Bill

On Wed, Nov 14, 2012 at 2:03 PM, Matt McCormick
<matt.mccormick at kitware.com> wrote:
> Hi Bill,
>
> It was expected to fail on most platforms, but that was expected.  The
> fix from JC had to committed to the MetaIO repository, which then
> automatically gets committed to the ITK and VTK repository.
>
> Unfortunately, I screwed up the MetaIO commit.  I just made a new one
> to fix the problem.
>
> So, it was good that we had a test :-).
>
> Matt
>
> On Wed, Nov 14, 2012 at 4:59 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> Brad,
>>
>> That is a kind remark. I would say it is pretty much failing on all platforms.
>>
>> Also, the robot test was failing.
>>
>> Why was this merged?
>>
>> Bill
>>
>> On Wed, Nov 14, 2012 at 10:30 AM, Bradley Lowekamp (Code Review)
>> <review at kitware.com> wrote:
>>> Bradley Lowekamp has posted comments on this change.
>>>
>>> Change subject: BUG: Add test for MetaIO vessel tube from getting stuck in while loop
>>> ......................................................................
>>>
>>>
>>> Patch Set 3:
>>>
>>> This new test is failing on a variety of platforms!
>>>
>>> http://open.cdash.org/testSummary.php?project=2&name=itkReadVesselTubeSpatialObjectTest&date=2012-11-14
>>>
>>> --
>>> To view, visit http://review.source.kitware.com/8449
>>> To unsubscribe, visit http://review.source.kitware.com/settings
>>>
>>> Gerrit-MessageType: comment
>>> Gerrit-Change-Id: Id80b18568f848da228c44cbc24fead1ebf05820f
>>> Gerrit-PatchSet: 3
>>> Gerrit-Project: ITK
>>> Gerrit-Branch: master
>>> Gerrit-Owner: Jean-Christophe Fillion-Robin <jchris.fillionr at kitware.com>
>>> Gerrit-Reviewer: Bill Lorensen <bill.lorensen at gmail.com>
>>> Gerrit-Reviewer: Hans J. Johnson <hans-johnson at uiowa.edu>
>>> Gerrit-Reviewer: Jean-Christophe Fillion-Robin <jchris.fillionr at kitware.com>
>>> Gerrit-Reviewer: Matt McCormick <matt.mccormick at kitware.com>
>>
>>
>>
>> --
>> Unpaid intern in BillsBasement at noware dot com



-- 
Unpaid intern in BillsBasement at noware dot com