[ITK-users] Procedure for Submitting Patches to Remote Modules/Third Party Libraries

[Matt McCormick]

Hi Davis,

Thanks for contributing fixes to these projects!

For GDCM, if you make a change to the source code in the ITK tree, it
will give instructions on how to submit the patch upstream [1].

For the remote module, please create a pull request on the
InsightSoftwareConsortium GitHub repository.  In the pull request,
make a comment that pings authors in the history of the repository,
like "please review @thewtex" so that reviewers are notified of the
change. After the change has been made, the Remote Module in ITK can
be updated by changing the sha in Modules/Remote/*.remote.cmake.

Thanks,
Matt


[1] https://github.com/InsightSoftwareConsortium/ITK/blob/master/Utilities/Hooks/post-commit

On Tue, Sep 29, 2015 at 4:24 PM, DVigneault <davis.vigneault at gmail.com> wrote:
> All--
>
> Is the procedure for submitting a patch for (a) a remote module or (b) a
> third party library different from the typical procedure [1]?  I'm wondering
> whether the patch is submitted as usual and then forwarded, or if the patch
> should be submitted directly to the original repository.  (Specifically I'm
> thinking of GDCM [2] and the Subdivision module [3].)
>
> Best, and thanks,
>
> --Davis
>
> [1]
> http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftwareProcess/SubmitAPatchToGerrit/index.html
> [2] https://github.com/malaterre/GDCM
> [3]
> https://github.com/InsightSoftwareConsortium/itkSubdivisionQuadEdgeMeshFilter
>
>
>
> --
> View this message in context: http://itk-insight-users.2283740.n2.nabble.com/Procedure-for-Submitting-Patches-to-Remote-Modules-Third-Party-Libraries-tp7587948.html
> Sent from the ITK Insight Users mailing list archive at Nabble.com.
> _____________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://www.kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/insight-users