[Insight-developers] Okay to remove protected helper function, ExceptionObject::UpdateWhat()?

Bill Lorensen bill.lorensen at gmail.com
Tue May 27 15:35:13 EDT 2008


Brad,

I'm sorry, but this is another compatibility discussion.

That is not a very customer-focused view. Is there a reason this
method was not declared private? You wrote it. To be honest, I have
not even looked at the code. Is there a technical reason why we should
not keep the method?

Bill

On Tue, May 27, 2008 at 2:23 PM, Brad King <brad.king at kitware.com> wrote:
> Bill Lorensen wrote:
>> Ah, but we have no way of knowing... do we
>
> Yes, we do.  We take it out and wait for a user to complain, treat it as
> a bug at that point, and fix it.  I don't want to get into yet another
> compatibility discussion, but if we support every single possible way a
> user could have been using our (undocumented) code forever then ITK will
> bloat even more.  We should at least use the legacy/deprecation scheme.
>
> -Brad
>
>> On Tue, May 27, 2008 at 1:46 PM, Brad King <brad.king at kitware.com> wrote:
>>> Bill Lorensen wrote:
>>>> Since it is protected and not private, it is possible that someone's
>>>> subclass is using it. Some subclass written by an ITK customer.
>>>>
>>>> Why can't we just leav it?
>>> I don't care either way, but I bet no one has ever touched that method.
>>>
>>> -Brad
>>>
>
>


More information about the Insight-developers mailing list