[Insight-developers] ITK version numbers

[Johnson, Hans J]

David,

I like the points you make below.

Hans


On 12/20/11 6:23 AM, "David Cole" <david.cole at kitware.com> wrote:

>Yes, of course we have the technology to do it.
>
>I am still of the opinion that it should not be based on a nightly
>heartbeat commit that's done by a robot, and that it should be updated
>only when necessary, by a developer, when he introduces an
>incompatible change that would necessitate a differentiation between
>"before" and "after" his change. (Which should be very infrequent,
>given our penchant for maintaining backwards compatibility.)
>
>NO DATE.
>
>Or if it is a date, then NO automatic daily updating of the date. Only
>manual updating when necessary.
>
>
>Staunchly against unnecessary commits of any kind,
>David C.
>
>
>On Mon, Dec 19, 2011 at 11:06 PM, Bill Lorensen <bill.lorensen at gmail.com>
>wrote:
>> vtk has a nightly version # and does not cause rebuilds every day.
>>
>> itk used to have a nightly version number. I think it just
>> incremented. It did not cause rebuilds.
>>
>> We have (or had) the technology to do it.
>>
>>
>> On Mon, Dec 19, 2011 at 5:24 PM, Matt McCormick
>> <matt.mccormick at kitware.com> wrote:
>>> We already have a .cxx file with an API in itkVersion.{h,cxx}.  The
>>> pre-processors macros will need to be removed from both the
>>> itkConfigure.h and itkVersion.h.  Then, itkVersion.cxx will need to
>>> include a new header that has the macros.
>>>
>>> Matt
>>>
>>> On Mon, Dec 19, 2011 at 5:22 PM, Bradley Lowekamp
>>> <blowekamp at mail.nih.gov> wrote:
>>>> We need the defines in some header, so we can use the pre-processor
>>>>to say if v4 do this new thing, otherwise do this legacy thing. I
>>>>think itkVersion.h is the place for this preprocessor definition.
>>>>
>>>> Brad L.
>>>>
>>>> On Dec 19, 2011, at 5:16 PM, Johnson, Hans J wrote:
>>>>
>>>>> I agree with Brad King.  It is best to put this into a .cxx file and
>>>>> provide an API.
>>>>>
>>>>> Hans
>>>>>
>>>>> --
>>>>> Hans J. Johnson, Ph.D.
>>>>> hans-johnson at uiowa.edu
>>>>> Assistant Professor of Psychiatry
>>>>> University of Iowa Carver College of Medicine
>>>>> W278 GH, 200 Hawkins Drive
>>>>>
>>>>> Iowa City, Iowa 52242
>>>>> Phone:  319-353-8587
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: Brad King <brad.king at kitware.com>
>>>>> Date: Mon, 19 Dec 2011 17:09:13 -0500
>>>>> To: Matt McCormick <matt.mccormick at kitware.com>
>>>>> Cc: Bradley Lowekamp <blowekamp at mail.nih.gov>, ITK
>>>>> <insight-developers at itk.org>, Hans Johnson <hans-johnson at uiowa.edu>,
>>>>>Luis
>>>>> Ibanez <luis.ibanez at kitware.com>
>>>>> Subject: Re: [Insight-developers] ITK version numbers
>>>>>
>>>>> On Mon, Dec 19, 2011 at 5:06 PM, Matt McCormick
>>>>> <matt.mccormick at kitware.com> wrote:
>>>>>> This is a very good point.  We have itkVersion.h in ITKCommon that
>>>>>>is
>>>>>> included by many of the IO files, which will cause full rebuilds for
>>>>>> most of WrapITK, SimpleITK, and ITK if trying to use ccache.
>>>>>
>>>>> We should keep the configured version number in a .cxx file and
>>>>>provide an
>>>>> API to retrieve it at runtime.
>>>>>
>>>>> -Brad K
>>>>>
>>>>>
>>>>>
>>>>> ________________________________
>>>>> Notice: This UI Health Care e-mail (including attachments) is
>>>>>covered by the Electronic Communications Privacy Act, 18 U.S.C.
>>>>>2510-2521, is confidential and may be legally privileged.  If you are
>>>>>not the intended recipient, you are hereby notified that any
>>>>>retention, dissemination, distribution, or copying of this
>>>>>communication is strictly prohibited.  Please reply to the sender
>>>>>that you have received the message in error, then delete it.  Thank
>>>>>you.
>>>>> ________________________________
>>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>>
>> --
>> Unpaid intern in BillsBasement at noware dot com
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________