[Insight-developers] ITKv4 Module Names

[Gaëtan Lehmann]

Le 10 févr. 11 à 15:20, Brad King a écrit :

> Hi Folks,
>
> After debate with Bill Lorensen in the "ITKv4 Modularization Plan"  
> thread:
>
>  http://www.itk.org/mailman/private/insight-developers/2011-February/017095.html
>
> about the module names, we looked into a new layout and naming that  
> is closer
> to existing ITK conventions.  I updated the CMake code that  
> implements the
> module infrastructure to make module names and locations totally  
> independent.
>
> Please see the attached file for the proposed names and layout.  For  
> example,
> the line
>
> itk-anisotropic-smoothing  ITK-AnisotropicSmoothing  ITK/Filtering/ 
> AnisotropicSmoothing
>
> proposes to rename the itk-anisotropic-smoothing to ITK- 
> AnisotropicSmoothing and
> relocate its source tree position from
>
>  modules/itk-anisotropic-smoothing
>
> to
>
>  ITK/Filtering/AnisotropicSmoothing
>
> Note that the "Filtering" directory diverges from the previous flat  
> layout
> We still treat the modules logically as a flat set but just organize  
> the
> source directory structure a bit.  Future re-organization of the  
> directory
> layout will not require any code changes.  The CMake code simply  
> globs for
> modules with
>
>  <top>/*/*/itk-module.cmake
>  <top>/*/*/*/itk-module.cmake
>
> which allows up to two levels of grouping.  The first level is always
> just "ITK/" for our modules but others that merge ITK into their  
> source
> can add "MyCompany/" modules too.
>
> The attached file is just a rough draft.  I need help with choosing  
> the
> final CamelCase appearance of each module name.  Also, it doesn't  
> account
> for a couple of new modules that were added in the last day or 2 but
> I think the idea is clear.
>
> Comments?

IO-Base and IO-Raw look a bit strange, aren't they? Shouldn't they be  
placed in the IO group?

I don't like much the 2 levels of directories, as it is sometime  
redundant with the module name. I also guess that's because of them  
that we have the strange IO-Raw and IO-Base?

Several IO modules don't have at least their first letter in  
uppercase, like ITK-IO-jpeg. I suppose their name should match the  
name of the class in ITK.

Just a small proposition, after a few years of development with  
WrapITK: it may be nice to have the name of the module in the cmake  
file of that module, so when one developer has several of them open on  
his computer, he can now simply with the name from which module it  
comes. I'll probably do that in WrapITK, because all those  
CMakeLists.txt don't have much meaning.
The glob would then be

  <top>/*/*/*itk-module.cmake
  <top>/*/*/*/*-itk-module.cmake

Gaëtan

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.itk.org
http://www.mandriva.org  http://www.bepo.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110210/0bb686a1/attachment.pgp>